Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: "Expected identifier, string or number" on Edge-18 #47

Closed
vbartusevicius opened this issue Mar 30, 2020 · 6 comments
Closed

Error: "Expected identifier, string or number" on Edge-18 #47

vbartusevicius opened this issue Mar 30, 2020 · 6 comments

Comments

@vbartusevicius
Copy link

On latest Edge-18 I'm getting this error: "Expected identifier, string or number".
To see it, please go to https://x5e7o.csb.app/ with Edge-18 - this is the output from https://codesandbox.io/s/distracted-elgamal-x5e7o.

Basically it complains about the spread operators in slugify/index.js. I don't see any supported platforms by this package, but could it be possible to support latest Edge-18 ?

eseQ added a commit to eseQ/slugify that referenced this issue Mar 31, 2020
Today object Rest/Spread Properties for ECMAScript is proposal. Without any compilation like babel it is break some browser (i.e. etc)
sindresorhus#47 issue about this
@eseQ
Copy link

eseQ commented Mar 31, 2020

@vbartusevicius wait for merge PR =)

@sindresorhus
Copy link
Owner

Sorry, I'm not interested in supporting Edge 18.

@vbartusevicius
Copy link
Author

@sindresorhus could you tell why? It's just a matter of spread vs Object.assign. Even when somebody already submitter PR

@eseQ
Copy link

eseQ commented Apr 1, 2020

@vbartusevicius hmmm this is strange but ok

@vbartusevicius
Copy link
Author

I think @sindresorhus is a bit too arrogant. @eseQ - thanks for PR, but will have to look for more open-minded library.

@eseQ
Copy link

eseQ commented Apr 1, 2020

@vbartusevicius we can just be thankful for @sindresorhus open-source work. Really.
For IE support you can use my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants