Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep option causes infinite recursion on indirectly circular objects #2

Closed
nathanfdunn opened this issue May 5, 2016 · 1 comment
Closed

Deep option causes infinite recursion on indirectly circular objects #2

nathanfdunn opened this issue May 5, 2016 · 1 comment

Comments

@nathanfdunn
Copy link
Contributor

nathanfdunn commented May 5, 2016 •
edited 

var sortKeys = require('sort-keys');
var obj = {};
obj.nested = {original: obj};
sortKeys(obj, {deep: true});            //stack overflow
@nathanfdunn nathanfdunn mentioned this issue May 6, 2016
Closed
sindresorhus pushed a commit that referenced this issue May 18, 2016
@nathanfdunn @sindresorhus
Fixed behavior for deep sort of circular objects
bdb0bb6 
Fixes issues detailed in issues #2 and #3.

Closes #4
sindresorhus pushed a commit that referenced this issue May 18, 2016
@nathanfdunn @sindresorhus
Fixed behavior for deep sort of circular objects
b698b51 
Fixes issues detailed in issues #2 and #3.

Closes #4
@sindresorhus
Copy link
Owner

Fixed by b698b51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @nathanfdunn