Require Node.js 8 and update is-plain-obj dependency
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme.md
Outdated
| @@ -50,7 +50,7 @@ Recursively sort keys. | |||
|
|
|||
| ##### compare | |||
|
|
|||
| Type: `Function` | |||
| Type: `function` | |||
There was a problem hiding this comment.
This one should actually be uppercase. I'm following TS types syntax. sindresorhus/meta#1 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional commit performs the
Meta tweaksI've seen you do as follow-up on many repos, I hope this is correct / helpful.Please do not release right away, I have a followup commit to expand handling of
deep: truefor arrays, for example to sort the deep object in{a: [[{b: 0, a: 0}]]}. The additional commit is coreyfarrell@584aa10, it adds a fair amount of complexity to this module so I figure it'd be better to post a separate PR (if you ask I can add it here).