Support getting image as a string #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevva
commented
Jul 23, 2017
| @@ -3,7 +3,7 @@ const fs = require('fs'); | |||
| const iterm2Version = require('iterm2-version'); | |||
| const ansiEscapes = require('ansi-escapes'); | |||
|
|
|||
| class UnsupportedTerminal extends Error { | |||
| class UnsupportedTerminal extends Error { // eslint-disable-line unicorn/custom-error-definition | |||
There was a problem hiding this comment.
Didn't want to change this to UnsupportedTerminalError in case some users depends on checking the error name (could be highly unlikely though). This would need a major then.
There was a problem hiding this comment.
I changed it and did a major version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want to log the image directly, but instead get the string and log it manually later, like in https://github.com/kevva/ink-image.