This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Make the slider gray #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the slider grey by drawing another grey NSBezierPath on top of the blue slider.
|
Works great. Thank you 🙌 By the way, if you're looking for more Swift related issues with bounties, see: https://github.com/search?l=Swift&q=user%3Asindresorhus+is%3Aissue+is%3Aopen+label%3A%22%3Adollar%3A+Funded+on+Issuehunt%22&type=Issues This is the main priority issue: sindresorhus/Gifski#78 |
|
@Mortennn I just noticed a bug with this:
Notice how it also fills the right side of the knob. Also, the path you draw over it is not as round as the original blue one. |
|
I will look into that soon. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Makes the slider grey by drawing another grey NSBezierPath on top of the blue slider.