Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 0.20.0 fails to compile under yarn2 pnp #151

Closed
leaumar opened this issue Nov 25, 2020 · 5 comments
Closed

Bug: 0.20.0 fails to compile under yarn2 pnp #151

leaumar opened this issue Nov 25, 2020 · 5 comments

Comments

@leaumar
Copy link

leaumar commented Nov 25, 2020

Renovate-bot attempted to upgrade type-fest to 0.20.0 during the night. The CI build fails with the following:

tsc -b
.yarn/cache/type-fest-npm-0.20.0-9c17c80bf4-420f4bc536.zip/node_modules/type-fest/ts41/camel-case.d.ts(1,30): error TS2307: Cannot find module './utilities' or its corresponding type declarations.
.yarn/cache/type-fest-npm-0.20.0-9c17c80bf4-420f4bc536.zip/node_modules/type-fest/ts41/delimiter-case.d.ts(1,51): error TS2307: Cannot find module './utilities' or its corresponding type declarations.

Typescript 4.1.2

{
    "compilerOptions": {
        "incremental": true,
        "module": "commonjs",
        "noUncheckedIndexedAccess": true,
        "strict": true,
        "target": "es2020"
    }
}
@leaumar leaumar changed the title Bug: v.0.20.0 fails to compile under yarn2 pnp Bug: 0.20.0 fails to compile under yarn2 pnp Nov 25, 2020
@sindresorhus
Copy link
Owner

@sindresorhus
Copy link
Owner

@voxpelli Any idea why the tsc run didn't catch this?

@leaumar
Copy link
Author

leaumar commented Nov 25, 2020

Build passes with 0.20.1, thank you

@voxpelli
Copy link
Collaborator

@sindresorhus The tsc isn't run on the ts41 folder as then it would fail on all the older TS versions, but the tsd should have caught it as its run on all files 🤔

@sindresorhus
Copy link
Owner

@voxpelli Ah yeah, my bad. I disabled tsd because it was failing on the normal tests. tsd will soon support TS 4.1. So I think we can just leave it until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants