Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PromiseValue #308

Closed
remcohaszing opened this issue Nov 3, 2021 · 3 comments · Fixed by #322
Closed

Deprecate PromiseValue #308

remcohaszing opened this issue Nov 3, 2021 · 3 comments · Fixed by #322
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@remcohaszing
Copy link

remcohaszing commented Nov 3, 2021 •
edited by polar-sh bot

microsoft/TypeScript#45350 introduces the Awaited type, which does the same thing (but more advanced).

This is part of TypeScript 4.5.

TypeScript blog

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@sindresorhus
Copy link
Owner

Yup. We should add a deprecation doc comment tag to the type and deprecate it in the docs. We will not remove it for a long time though.

@sindresorhus sindresorhus added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 3, 2021
@remcohaszing
Copy link
Author

My bad, Awaited is similar to PromiseValue, not Promisable.

@remcohaszing remcohaszing changed the title Deprecate Promisable Deprecate PromiseValue Nov 3, 2021
@liuhanqu
Copy link
Contributor

liuhanqu commented Nov 19, 2021 •
edited

#322
I create a PR to fix this issue

@liuhanqu liuhanqu mentioned this issue Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate PromiseValue type
3 participants
@sindresorhus @remcohaszing @liuhanqu