Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests no longer run with xo v0.52.2 #451

Closed
skarab42 opened this issue Aug 29, 2022 · 10 comments · Fixed by xojs/xo#687
Closed

Tests no longer run with xo v0.52.2 #451

skarab42 opened this issue Aug 29, 2022 · 10 comments · Fixed by xojs/xo#687

Comments

@skarab42
Copy link
Collaborator

skarab42 commented Aug 29, 2022

I have just done a fresh install from the main branch and it looks like xo cannot find the tsconfig.json file.

image

Even when adding the config in the package.json or in an .eslintrc doesn't change anything.

"eslintConfig": {
  "parserOptions": {
    "project": "./tsconfig.json"
  }
}

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@skarab42
Copy link
Collaborator Author

skarab42 commented Aug 29, 2022

@sindresorhus The latest version that works (with some errors/warnings that I didn't have before) is xo v0.43.0.
image

@sindresorhus
Copy link
Owner

Try to install with npm and see if that makes a difference.

@sindresorhus
Copy link
Owner

It works fine for me locally and it also works fine on the CI.

@skarab42
Copy link
Collaborator Author

Same with npm, yarn or pnpm on node v14 but i am on Windows...

@skarab42
Copy link
Collaborator Author

@sindresorhus this is related to windows, works on WLS but I don't understand what changed to make it break like that...
image

@sindresorhus
Copy link
Owner

Also make sure you have the latest minor version of Node.js 14 or 16.

@sindresorhus
Copy link
Owner

Does XO 0.51.0 work? Just to see if it's a reason problem.

@skarab42
Copy link
Collaborator Author

skarab42 commented Aug 29, 2022

Does XO 0.51.0 work? Just to see if it's a reason problem.

I have tested them all down to 0.43.0 which is the first one that works.

@skarab42
Copy link
Collaborator Author

@sindresorhus Same with latest node and npm version
image

Repository owner deleted a comment from imrane245 Aug 30, 2022
@skarab42
Copy link
Collaborator Author

@sindresorhus I think I found the issue in XO and so it's not related to type-fest. I'm closing this issue and doing a PR with a fix on the XO repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants