Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge merges optional any incorrectly #506

Closed
JuanM04 opened this issue Oct 25, 2022 · 4 comments · Fixed by #583
Closed

Merge merges optional any incorrectly #506

JuanM04 opened this issue Oct 25, 2022 · 4 comments · Fixed by #583
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@JuanM04
Copy link

JuanM04 commented Oct 25, 2022

In version 3.1.0, Merge works incorrectly

type Merged = Merge<{ someKey?: any }, { anotherKey: true }>;

// Before
type Merged = { someKey?: any; anotherKey: true }

// Now
type Merged = { someKey: any; anotherKey: true }

someKey now becomes required.
@sindresorhus
Copy link
Owner

// @skarab42

Most likely introduced in eb7f08b

@kykungz
Copy link

kykungz commented Mar 16, 2023

Will this get fixed?

@sindresorhus sindresorhus added bug Something isn't working help wanted Extra attention is needed labels Mar 18, 2023
@david-crespo david-crespo mentioned this issue Mar 27, 2023
Closed
@center-777
Copy link

eb7f08b

No, rollback not solves the problem

@skarab42
Copy link
Collaborator

I take a look this week-end

@skarab42 skarab42 mentioned this issue Mar 28, 2023
Merged
@Xananax Xananax mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Merge with optional any value skarab42/type-fest
5 participants
@sindresorhus @center-777 @kykungz @JuanM04 @skarab42