Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeDeep is never when compiled to .d.ts #780

Closed
dreinon opened this issue Dec 5, 2023 · 5 comments
Closed

MergeDeep is never when compiled to .d.ts #780

dreinon opened this issue Dec 5, 2023 · 5 comments

Comments

@dreinon
Copy link

dreinon commented Dec 5, 2023

I'm trying to use MergeDeep to redefine certain types from the type generation Supabase CLI does, like it says in the guide.

When I write the code, it works well, but when it is compiled to d.ts, it is never:
image
image

Any ideas? Thanks!

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@dreinon
Copy link
Author

dreinon commented Dec 11, 2023

@sindresorhus hi, sorry to tag but it's a bit important for my project. Any ideas of what could be causing this issue? Thanks!

@sindresorhus
Copy link
Owner

First, make sure you are on the latest type-fest version and you're using strict TS config.

We cannot really do much based on a screenshot. If you want to see this fixed sooner, I recommend submitting a minimal failing test: https://github.com/sindresorhus/type-fest/blob/main/test-d/merge-deep.ts

@dreinon
Copy link
Author

dreinon commented Dec 11, 2023

First, make sure you are on the latest type-fest version and you're using strict TS config.

We cannot really do much based on a screenshot. If you want to see this fixed sooner, I recommend submitting a minimal failing test: https://github.com/sindresorhus/type-fest/blob/main/test-d/merge-deep.ts

Thanks

@dreinon
Copy link
Author

dreinon commented Dec 12, 2023

using strict TS config solves the problem, may I know why? Thanks!

@sindresorhus
Copy link
Owner

I haven't look into it, but certain types are more limited when strict mode is off.

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants