Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nitrogen on linux #17

Merged
merged 11 commits into from
Jun 8, 2017
Merged

Add support for nitrogen on linux #17

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e716fd
Add support for nitrogen on linux
fa7ad Sep 1, 2016
84ae82a
add save flag to make changes permanent
fa7ad Sep 2, 2016
de623e1
Add get method for nitrogen
Oct 22, 2016
efe802b
fix the coding style issue
Oct 22, 2016
7125329
refactor the get method for nitrogen, fix #18
Nov 5, 2016
002c31e
make requested changes #17
Dec 6, 2016
5a995dd
fix promise chaining?
Dec 6, 2016
45e0732
let -> const
Dec 6, 2016
d58ce4c
Merge tag 'v2.4.0' into patch-1
Mar 18, 2017
1f2d990
fix promise chaining for linux set method
Mar 18, 2017
72357f3
fix `npm test` issus
Mar 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 22 additions & 12 deletions lib/linux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ const pify = require('pify');
const cp = pify(childProcess);

const appsList = [
{
cmd: 'gsettings',
set: ['set',
'org.cinnamon.desktop.background',
'picture-uri',
'file://%s'
],
get: ['get',
'org.cinnamon.desktop.background',
'picture-uri'
]
},
{
cmd: 'gsettings',
set: ['set',
Expand All @@ -31,6 +43,12 @@ const appsList = [
cmd: 'feh',
set: ['--bg-scale', '%s']
},
{
cmd: 'nitrogen',
set: ['--set-zoom-fill', '--save', '%s'],
get: ['-n', 's/^file=//p', `${process.env.HOME}/.config/nitrogen/bg-saved.cfg`],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a long flag for -n? If yes, use that instead.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use require('os').homedir() instead of the environment variable. Should also use path.join.

transform: imagePath => imagePath.trim().split('\n').slice(-1)[0]
},
{
cmd: 'xfconf-query',
set: ['-c xfce4-desktop',
Expand Down Expand Up @@ -63,18 +81,6 @@ const appsList = [
'/org/mate/desktop/background/picture-filename'
],
transform: imagePath => imagePath.slice(1, -1)
},
{
cmd: 'gsettings',
set: ['set',
'org.cinnamon.desktop.background',
'picture-uri',
'file://%s'
],
get: ['get',
'org.cinnamon.desktop.background',
'picture-uri'
]
}
];

Expand Down Expand Up @@ -124,6 +130,10 @@ exports.get = function get() {

const app = availableApps.find(app => app.get);

if (/nitrogen/.test(app.cmd)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (app.cmd === 'nitrogen') {

app.cmd = '/bin/sed';
}

return cp.execFile(app.cmd, app.get).then(stdout => {
stdout = stdout.trim();

Expand Down