Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When python.notification_center.channels is set as "" in ~/.weechat/plugins.conf, notification_center.py doesn't work.
I investigated this issue and noticed
if channel in channel_whitelist:
of line 63 returns True although channel whitelist is not registered.In Python,
"".split(',')
returns['']
and"" in ['']
returnsTrue
....To avoid the case, condition is set.
I confirmed the edited version of notification-center.py works in weechat.
If you would like to ask me more in detail, please let me know.