Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New line at EOF #26

Closed
privatenumber opened this issue Jul 17, 2019 · 1 comment · Fixed by #27
Closed

New line at EOF #26

privatenumber opened this issue Jul 17, 2019 · 1 comment · Fixed by #27
Labels
bug help wanted

Comments

@privatenumber
Copy link
Sponsor Contributor

I'm noticing that this adds a new line at the end of the file even when the existing JSON file doesn't have one. I am using this in detectIndent so I expected the whitespace to be left untouched.

Perhaps it could respect the EOF by default, or add a detectEOF option?

Happy to open a PR if we can decide on a direction with this issue.
@sindresorhus
Copy link
Owner

It should respect the EOF by default. No option needed, and a PR would be very welcome (test included) 👍

@privatenumber privatenumber mentioned this issue Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect trailing newline at the end of the file privatenumber/write-json-file
2 participants
@sindresorhus @privatenumber