Add extensions option
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn it on and you can lint files with any extension. That is, the filter ignoring all files that do not end in .js or .jsx is disabled.
|
I think the correct solution would be to introduce an |
This reverts commit c5d7ceb.
By default, xo filters out any non-js and non-jsx files. With this option you can add more extensions to the whitelist. Just make sure ESLint supports that format, either directly or with a plugin.
|
Changed it to the |
sindresorhus
requested changes
Oct 5, 2016
| @@ -42,6 +42,7 @@ const cli = meow(` | |||
| --extend Extend defaults with a custom config [Can be set multiple times] | |||
| --open Open files with issues in your editor | |||
| --quiet Show only errors and no warnings | |||
| --extension Additional extensions to lint [Can be set multiple times] | |||
| return ext === '.js' || ext === '.jsx'; | ||
| // Remove dot before the actual extension | ||
| const ext = path.extname(x).replace('.', ''); | ||
| return opts.extensions.indexOf(ext) > -1; |
There was a problem hiding this comment.
I considered using it but it seems like it's only supported since Node 6 (or node 5 with a flag): http://node.green/#Array-prototype-includes
There was a problem hiding this comment.
Agh, right. Forgot that.
Use !== -1
| @@ -197,6 +199,12 @@ Type: `Array`, `string` | |||
|
|
|||
| Use one or more [shareable configs](http://eslint.org/docs/developer-guide/shareable-configs.html) to override any of the default rules (like `rules` above). | |||
|
|
|||
| ### extensions | |||
|
|
|||
| Type: `Array`, `string` | |||
👍 |
|
And PR title needs to be updated |
abread
changed the title
extensions option takes in an array, not a string --extension option adds one extension per use, not multiple
.indexOf(..) !== -1 instead of > -1
The filter removes the need to specify extensions manually.
abread
force-pushed
the
more_extensions
branch
from
ca33acd
to
bc9c349
Compare
sindresorhus
changed the title
extensions option
sindresorhus
approved these changes
Oct 7, 2016
|
Looks great! Thanks @addobandre :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #117 (Allowing more file extensions)
Trying to detect whether the glob pattern restricts file extensions quickly gets out of hand. There are arrays of patterns, there can be negations, obscure regex syntax that may not be accounted for and that does limit what extensions can be used...
So, I added a new option: anyExtension (or --any-extension).
Set it to true, and the extension filter is disabled.
In my opinion, it would be better to just remove it altogether. Most people are probably just using the default expression and the ignores option, so impact should be minimal. A FAQ entry would be fine. Maybe this should happen for 1.0?