Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming conventions/coding standards #24

Closed
sinewalker opened this issue May 31, 2017 · 3 comments
Closed

naming conventions/coding standards #24

sinewalker opened this issue May 31, 2017 · 3 comments
Assignees
@sinewalker
Labels
enhancement
Projects
macOS
Milestone
1.1-SUSE

Comments

@sinewalker
Copy link
Owner

sinewalker commented May 31, 2017 •
edited

Naming conventions

Functions and variables should have the following naming conventions applied consistently in dotfiles

See the wiki page for the details.

While that page may change a bit, this issue can be closed for purposes of the 1.0-macOS Milestone once the code is meeting the guidelines I've compiled when I close the issue.
@sinewalker sinewalker added this to the 1.0-macOS milestone May 31, 2017
@sinewalker sinewalker changed the title naming conventions naming conventions/coding standards May 31, 2017
@sinewalker
Copy link
Owner Author

Once this has been Made So, it deserves its own Wiki page

@sinewalker sinewalker self-assigned this Aug 22, 2017
@sinewalker sinewalker added this to In progress in macOS Aug 22, 2017
@sinewalker sinewalker mentioned this issue Oct 14, 2017
Open
@sinewalker
Copy link
Owner Author

this is about 3/4 complete. Descoping from macOS because:

@sinewalker sinewalker modified the milestones: 1.0-macOS, 1.1-SUSE Oct 14, 2017
sinewalker added a commit that referenced this issue Oct 15, 2017
@sinewalker
coding standards - variable references
33c462c 
For Issue #24
sinewalker added a commit that referenced this issue Oct 15, 2017
@sinewalker
rename private/internal functions with underscores
628131b 
This prevents contaminating the shell completion with functions that aren't
supposed to be run interactively

Issue #24
sinewalker added a commit that referenced this issue Oct 16, 2017
@sinewalker
add function description to dedupe_path()
9356521 
Also clean up variable references

Issue #23
Issue #24
sinewalker added a commit that referenced this issue Oct 17, 2017
@sinewalker
self-document interactive dotfiles functions
e1bdffe 
Issue #24
@sinewalker sinewalker moved this from In progress to done in macOS Mar 17, 2018
@sinewalker
Copy link
Owner Author

I think I've done it all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinewalker sinewalker

Labels
enhancement
Projects
No open projects
macOS
done
Milestone
1.1-SUSE
Development

No branches or pull requests
1 participant
@sinewalker