Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotfiles picks the ubuntu init script on SUSE #44

Closed
sinewalker opened this issue Apr 1, 2018 · 2 comments
Closed

dotfiles picks the ubuntu init script on SUSE #44

sinewalker opened this issue Apr 1, 2018 · 2 comments
Labels
Milestone

Comments

@sinewalker
Copy link
Owner

sinewalker commented Apr 1, 2018

It shouldn't be picking ubuntu on a SUSE machine; that should only be chosen on ubuntu.

Run the following init scripts?
 ✖  10_osx_xcode.sh
 ✖  20_osx_homebrew.sh
 ✔  20_ubuntu_apt.sh
 ✖  30_osx_homebrew_casks.sh
 ✖  30_osx_homebrew_recipes.sh
 ✔  50_fonts.sh
 ✖  50_node.bug
 ✔  50_python.sh
 ✔  50_vagrant.sh
To edit this list, press any key within 8 seconds.

Either the logic to deselect it is flawed, or the logic to detect ubuntu gets a false positive when on SUSE (tumbleweed)

@sinewalker sinewalker added the bug label Apr 1, 2018
@sinewalker sinewalker added this to the 1.1-SUSE milestone Apr 1, 2018
@sinewalker
Copy link
Owner Author

[mjl@hoppy:~]
[16:45]$ is_ubuntu 
[mjl@hoppy:~]
[16:45] 1 $ 

okay, so it's not is_ubuntu's fault.

@sinewalker
Copy link
Owner Author

sinewalker commented Apr 1, 2018

It correctly picks a suse file (made by touching):

Run the following init scripts?
 ✖  10_osx_xcode.sh
 ✔  10_suse_thing.sh
 ✖  20_osx_homebrew.sh
 ✔  20_ubuntu_apt.sh
 ✖  30_osx_homebrew_casks.sh
 ✖  30_osx_homebrew_recipes.sh
 ✔  50_fonts.sh
 ✖  50_node.bug
 ✔  50_python.sh
 ✔  50_vagrant.sh
To edit this list, press any key within 8 seconds. 

sinewalker added a commit that referenced this issue Apr 1, 2018
This was breaking as soon as it removed the first entry, which prevents it from
removing any more.

Issue #44
@sinewalker sinewalker modified the milestones: 1.1-SUSE, 1.0-macOS Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant