Feature: currently_syncing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds
currently_syncingoption toget-selected-streams, if the key is contained in the state. Expands tests to cover some common cases for this feature. This is accomplished with a new arity forget-selected-streamsto maintain backwards compatibility and provide this feature as an option.NOTE: The implementation here is explicitly designated to NOT shuffle the streams in the case that a bookmarked stream has been deselected or no longer exists in the catalog. In these cases, syncing will begin from the first stream.
Manual QA steps
Risks
Rollback steps