Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages, catalog, parse namespaces #4

Merged
merged 14 commits into from
May 21, 2020

Conversation

nick-mccoy
Copy link
Contributor

Description of change

Adds 3 new namespaces

  • messages
  • catalog
  • parse

Manual QA steps

  • wrote unit tests for all funcs

Risks

  • n/a

Rollback steps

  • revert this branch

@nick-mccoy nick-mccoy changed the title Add/messages and catalog Add messages, catalog, parse namespaces May 20, 2020
Copy link
Collaborator

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty solid, just one comment and a potential change.

src/singer_clojure/messages.clj Outdated Show resolved Hide resolved
test/singer_clojure/catalog_test.clj Show resolved Hide resolved
* Fixed comments
* Added is with better message to pre/post conditions
Copy link
Collaborator

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question/comment/change

src/singer_clojure/parse.clj Outdated Show resolved Hide resolved
@asaf-erlich asaf-erlich merged commit 8e49c48 into master May 21, 2020
@asaf-erlich asaf-erlich deleted the add/messages-and-catalog branch May 21, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants