-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messages, catalog, parse namespaces #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mccoy
changed the title
Add/messages and catalog
Add messages, catalog, parse namespaces
May 20, 2020
asaf-erlich
reviewed
May 20, 2020
asaf-erlich
reviewed
May 20, 2020
asaf-erlich
reviewed
May 20, 2020
asaf-erlich
reviewed
May 20, 2020
asaf-erlich
reviewed
May 20, 2020
…r-clojure into add/messages-and-catalog
KAllan357
reviewed
May 20, 2020
luandy64
reviewed
May 20, 2020
dmosorast
requested changes
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty solid, just one comment and a potential change.
luandy64
reviewed
May 20, 2020
asaf-erlich
reviewed
May 21, 2020
asaf-erlich
reviewed
May 21, 2020
asaf-erlich
reviewed
May 21, 2020
* Fixed comments * Added is with better message to pre/post conditions
dmosorast
requested changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question/comment/change
dmosorast
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds 3 new namespaces
Manual QA steps
Risks
Rollback steps