Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exceptions #138

Merged
merged 3 commits into from Feb 3, 2021
Merged

Add exceptions #138

merged 3 commits into from Feb 3, 2021

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Feb 2, 2021

Description of change

This PR adds base exception classes for taps to use.

Manual QA steps

  • Added and ran unit tests

Risks

  • I want to be conservative about what makes it into this file this early. I want to avoid cluttering the namespace with classes that turn out to be specific to just a few taps

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit bfa184e into master Feb 3, 2021
@luandy64 luandy64 deleted the add-exceptions branch February 3, 2021 14:53
@luandy64 luandy64 mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobrobertbaca jacobrobertbaca jacobrobertbaca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luandy64 @jacobrobertbaca