Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version of requests library #13

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

mbreault
Copy link
Contributor

Our security team got an alert about a cve in https://github.com/singer-io/tap-appsflyer/blob/master/setup.py. specifically that 'requests==2.12.4', should be updated to 2.20.0 or newer.

@cmerrick
Copy link
Contributor

Hi @mbreault, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@dmosorast
Copy link
Contributor

Thanks for the submission @mbreault! I'm prepared to merge this once we get confirmation about the contribution agreement.

@mbreault
Copy link
Contributor Author

mbreault commented Nov 1, 2018

Thanks for the submission @mbreault! I'm prepared to merge this once we get confirmation about the contribution agreement.

I completed the contribution agreement the day I did the PR. Is there something else I need to do?

@dmosorast
Copy link
Contributor

@mbreault Ah! I see now. The webhook must have been dropped at the time so I didn't receive the notification. Sorry for the delay, thanks a bunch! I'll get this merged now.

@dmosorast dmosorast merged commit 0df0fe1 into singer-io:master Nov 1, 2018
@cmerrick
Copy link
Contributor

cmerrick commented Nov 1, 2018

You did it @mbreault!

Thank you for signing the Singer Contribution License Agreement.

@mbreault mbreault deleted the mb-update-version-requests branch November 1, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants