Iterate over in-app-events by using a shorter query window #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosorast
reviewed
Jul 11, 2018
tap_appsflyer/__init__.py
Outdated
|
|
||
| # Move the timings forward | ||
| from_datetime = to_datetime | ||
| to_datetime = get_stop(from_datetime, stop_time) |
There was a problem hiding this comment.
Should this be passing 10 as well? Or do we just want to do two rounds through the timespan?
There was a problem hiding this comment.
I was just going to keep the default 30 here as it wasn't causing an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The side effect here is that certain "raw" reports can only be called 10 (or more depending on account tier) times per day.
https://support.appsflyer.com/hc/en-us/articles/207034366-API-Policy
We've now had at least one case where a query for a month's data doesn't return for more than 5 hours.