[TDL-24569] New Stream inclusion: subtasks #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
reviewed
Dec 8, 2023
| "format": "date-time" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add blank/empty line at the end of file
rdeshmukh15
reviewed
Dec 8, 2023
| return subtasks + subtasks_children | ||
|
|
||
|
|
||
| Context.stream_objects["subtasks"] = SubTasks |
There was a problem hiding this comment.
Add the empty line at the end of the file and wherever it is missing
There was a problem hiding this comment.
i am trying to keep it consistent. since all the other stream files don't have a new line at EOF, i will skip these formatting changes.
rdeshmukh15
reviewed
Dec 11, 2023
| # running sync with multiple date timestamps accross different streams due to differences in bookmark values | ||
| self.run_test("2021-11-09T00:00:00Z", "2023-11-10T00:00:00Z", {"projects",}) | ||
| self.run_test("2023-11-28T00:00:00Z", "2023-11-30T00:00:00Z", {"subtasks",}) | ||
| self.run_test("2019-01-28T00:00:00Z", "2023-11-30T00:00:00Z", self.expected_streams() - {"subtasks","projects"}) |
There was a problem hiding this comment.
Any reason, third execution doesn't have subtasks and projects streams?
There was a problem hiding this comment.
all streams do not contain data in a singular date range, hence to validate bookmarking for all streams the tests are being run with different date ranges for these two specific streams
rdeshmukh15
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
subtasksstreamManual QA steps
Risks
Rollback steps