Changed product.external_id to string #13
Conversation
|
Hi @ericdigr, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
https://share.getcloudapp.com/v1ujPmGe |
|
we are using stitch and we have tons of similar errors — error logs |
tap_bigcommerce/schemas/orders.json
Outdated
| @@ -442,7 +442,7 @@ | |||
| } | |||
| }, | |||
| "external_id": { | |||
| "$ref": "type-integer.json" | |||
| "$ref": "type-string.json" | |||
There was a problem hiding this comment.
I did some digging, and it looks like this specific issue isn't widespread. Given that this is pretty impactful, since the tap seems to silently drop all data that doesn't match the schema, I'm willing to merge it, as long as the change is backwards compatible. In this case, that would mean making the schema a fallback from most specific to least specific, e.g., something like {"type": ["integer", "string", "null"]}.
If you could make that change, and show redacted logs of the tap extracting data successfully (to ensure the JSON schema syntax is correct), then I would be willing to merge this change.
There was a problem hiding this comment.
@dmosorast changes made to row 444 with fallback
|
You did it @ericdigr! Thank you for signing the Singer Contribution License Agreement. |
Description of change
product.external_id is defined as a string in the BigCommerce v2 API documentation. This request is related to issue #14, where external_id's in the BigCommerce source are strings and the insert fails for these orders.
The BigCommerce API docs which indicate the external_id is a string [(https://developer.bigcommerce.com/api-reference/store-management/orders/orders/createanorder)]
Screenshot of the API doc:
https://share.getcloudapp.com/v1ujPmGe
Manual QA steps
Verify string external_ids are being passed through the Tap
Risks
Rollback steps