-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to line 430 to accept number and string #18
Open
shikharjaiswal67
wants to merge
7
commits into
singer-io:master
Choose a base branch
from
shikharjaiswal67:tap-bc-orders
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cfc2645
changes to line 430 to accept int and string
shikharjaiswal67 8ff8b14
changes to line 430 to accept number and string
shikharjaiswal67 3b48185
changes to line 430 to accept number and string
shikharjaiswal67 21f2ce0
Merge branch 'master' into tap-bc-orders
shikharjaiswal67 9539a1f
change to line 430 in orders.json to string type
177c7f2
fixed the line 430 in orders.json to type to
23e7719
removed the duplicate branch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shikharjaiswal67,
I was wondering about the necessity of maintaining two separate datatypes. The documentation specifically mentions the datatype as
string
. Should we consider eliminating thenumber
datatype altogether?Having both datatypes may lead to the creation of two columns in the destination table, each with a different datatype (number and string). What are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @sgandhi1311 ,
Agreed with you as there is no need for both datatypes. I will create update the PR and let you know.