Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to line 430 to accept number and string #18

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_bigcommerce/schemas/orders.json
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@
"$ref": "type-string.json"
},
"value": {
"$ref": "type-number.json"
"type": ["number", "string", "null"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shikharjaiswal67,

I was wondering about the necessity of maintaining two separate datatypes. The documentation specifically mentions the datatype as string. Should we consider eliminating the number datatype altogether?

Having both datatypes may lead to the creation of two columns in the destination table, each with a different datatype (number and string). What are your thoughts on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sgandhi1311 ,

Agreed with you as there is no need for both datatypes. I will create update the PR and let you know.

},
"type": {
"$ref": "type-string.json"
Expand Down