forked from envoy/tap-chargebee
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all minimum/maximum and minLength/maxLength #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a wonderful lesson about the need to run the code for all PRs, no matter how small, this and #44 have invalid JSON due to trailing commas left behind. I can't update this PR right now, but it definitely suffers from the same problem. |
karanpanchal-crest
approved these changes
Jun 22, 2021
…nto remove-restrictive-json-schema-props
…nto remove-restrictive-json-schema-props
KAllan357
approved these changes
Jun 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In a similar vein as #44, I would like to remove all of the restrictive properties from this schema so that the tap doesn't need to manually evolve in sync with the Chargebee API.
However, I don't have an account to test this (and I'm not familiar with the semantics of this data). So, I'd like to get someone familiar with the data and service, and ideally someone who can run the tap to confirm that it runs successfully with target-stitch if possible so that I can confirm that the Stitch Import API will accept actual records with the new schemas (to fix errors like in issue #43).
Manual QA steps
Risks
Rollback steps