Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdl 25352 add float to integer metric #102

Merged
merged 3 commits into from Mar 26, 2024

Conversation

sgandhi1311
Copy link
Member

@sgandhi1311 sgandhi1311 commented Mar 26, 2024

Description of change

The Google Analytics API reports a metric field with the data type INTEGER, but during the synchronization process, some records are returned as float values instead. To address this issue, this pull request proposes adding support for the NUMBER data type in the catalog for metric fields that are originally specified as INTEGER types in the Google Analytics API.

Manual QA steps

  • Performed PR-alpha on the customer connection.

Risks

  • Customers may encounter a column split in the destination database.

Rollback steps

  • revert this branch

@shantanu73 shantanu73 self-requested a review March 26, 2024 13:37
@sgandhi1311 sgandhi1311 merged commit f34ed88 into main Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants