Tdl 25352 add float to integer metric #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanu73
approved these changes
Mar 26, 2024
RushiT0122
pushed a commit
that referenced
this pull request
May 15, 2024
* In addition to integer add number for TYPE_INTEGER metric fields * setup and changelog update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The Google Analytics API reports a metric field with the data type INTEGER, but during the synchronization process, some records are returned as float values instead. To address this issue, this pull request proposes adding support for the NUMBER data type in the catalog for metric fields that are originally specified as INTEGER types in the Google Analytics API.
Manual QA steps
Risks
Rollback steps