Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date ranges for report data #43

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Add date ranges for report data #43

merged 2 commits into from
Apr 1, 2022

Conversation

bhtowles
Copy link
Contributor

Description of change

Document date ranges for report streams where data has been generated inside the sync_canary test for future reference.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

@bhtowles bhtowles added the testing QA work. No src code changes. label Mar 30, 2022
kspeer825
kspeer825 suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY minor, but could this be put inside the existing docstring for the test. Under test_run

@kspeer825 kspeer825 merged commit 7afa99a into main Apr 1, 2022
@kspeer825 kspeer825 deleted the qa/report-data-dates branch April 1, 2022 14:23
@bryantgray bryantgray mentioned this pull request Apr 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kspeer825 kspeer825 kspeer825 approved these changes

Assignees
No one assigned
Labels
testing QA work. No src code changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhtowles @kspeer825