Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api version changes to v15 #86

Merged
merged 5 commits into from Dec 13, 2023
Merged

Conversation

rdeshmukh15
Copy link
Contributor

@rdeshmukh15 rdeshmukh15 commented Nov 23, 2023

Description of change

  • Bump package version to 22.1.0
  • Api version upgrade to V15

QA steps

  • automated tests passing
  • manual qa steps passing

Risks

Rollback steps

  • revert this branch

@rdeshmukh15 rdeshmukh15 changed the title api version changes api version changes to v15 Nov 30, 2023
Copy link
Contributor

@dsprayberry dsprayberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we should probably investigate adding the new metrics added in version 14.1 and 15 (listed here and here respectively, but I don't want to block on that.

@rdeshmukh15 rdeshmukh15 merged commit 34b05a5 into main Dec 13, 2023
7 checks passed
dsaxton-1password added a commit to rae89/tap-google-ads that referenced this pull request Jan 9, 2024
* Make tap-tester suite use end_date to reduce test runtime (singer-io#71)

* Make tap-tester suite use end_date to reduce test run-time

* update integration tets to account for end date usage, add a unittest

* fix typo in tests

* save test logs as artifacts

Co-authored-by: kspeer <kspeer@stitchdata.com>

* TDL-21755 v11 and library bump (singer-io#79)

* v11 and library bump

* Trying another library version for tests

* protobuf version decrease to meet google ads lib reqs

* Version bump and changelog for PR 79 (singer-io#80)

* TDL-21689 and TDL-21756 Bump to v12 (singer-io#76)

* Bump google-ads client library to the minimum package version that
supports the v12 api

See https://developers.google.com/google-ads/api/docs/client-libs#python
for more details

* Update API_VERSION

* Remove fields

https://developers.google.com/google-ads/api/docs/diff-tool/v12/versus-v11/diffs/common/ad_type_infos

---------

Co-authored-by: Dylan Sprayberry <28106103+dsprayberry@users.noreply.github.com>

* Changelog entry and version bump for PR 76 (singer-io#78)

* google-ads updated api version to V13 (singer-io#82)

* updated api version to V13
* updated changelog

* api version changes to v15 (singer-io#86)

* api version changes

* removed segments.product_bidding_category_level1

* removed segments.product_bidding_category_level2,3,4 and 5

* adding again product_bidding_category_level fields

* product_bidding_category_level... replaced with product_category_level..

---------

Co-authored-by: Dylan <28106103+dsprayberry@users.noreply.github.com>
Co-authored-by: kspeer <kspeer@stitchdata.com>
Co-authored-by: Andy Lu <andy@stitchdata.com>
Co-authored-by: Vishal <vpachpinde@talend.com>
Co-authored-by: rdeshmukh15 <107538720+rdeshmukh15@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants