Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse datetimes using Google's format #22

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

dmosorast
Copy link
Contributor

Description of change

Correct the datetime parsing behavior for fields in the Time group. These come back using non-ISO types, so they were being rejected by the Transformer.

This adds a step before writing the records that will parse them as datetimes and convert them to ISO-8601 format (at UTC timezone).

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran through a manual sync and inspected the values at each conversion step.

Risks

  • Medium, I'm adding a new field to the datetime types mapping, which could result in mixed datatypes for some users.

Rollback steps

  • revert this branch, bump patch version and re-release

Copy link
Contributor

@luandy64 luandy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would've looked nicer with a clojure thread-first, but 👍

@dmosorast dmosorast merged commit 674a5af into master May 18, 2020
@dmosorast dmosorast deleted the fix/datetime-parsing branch May 18, 2020 15:00
@dmosorast dmosorast mentioned this pull request May 18, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants