TDL-19422 add new streams #34
Conversation
| "conversation_id": { | ||
| "type": ["null", "integer"] |
There was a problem hiding this comment.
This is a key_property; is it actually possible for it to be null? If not, we should remove the null type.
There was a problem hiding this comment.
I'm going to remove null because I'm 100% confident that these fields can never null from source API response.
I observed for most of the integrations we included null for PKs, I feel this is just to avoid unwanted loading errors if by mistake any field comes as null from source API
Examples:
| "rating_customer_id": { | ||
| "type": ["null", "integer"] |
There was a problem hiding this comment.
This is a key_property; is it actually possible for it to be null? If not, we should remove the null type.
| "rating_created_at": { | ||
| "type": ["null", "string"], |
There was a problem hiding this comment.
This is a key_property; is it actually possible for it to be null? If not, we should remove the null type.
Description of change
This PR adds three new streams for tap-helpscout:
Manual QA steps
Risks
Rollback steps