Tdl 21819 tickets stream dev changes #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
force-pushed
the
TDL-21819-tickets-stream-dev-changes
branch
from
fadb7e7
to
9dfc7d9
Compare
rdeshmukh15
force-pushed
the
TDL-21819-tickets-stream-dev-changes
branch
from
7ed033b
to
06b1b94
Compare
kethan1122
suggested changes
Feb 7, 2023
|
Don't forget to update README |
bryantgray
reviewed
Feb 7, 2023
| mocked_gen_request.assert_called_once_with(ANY, ANY, ANY, expected_param, ANY, ANY) | ||
|
|
||
|
|
||
| output_results = {'results': [ |
There was a problem hiding this comment.
Formatting of this should be cleaned up.
tap_hubspot/__init__.py
Outdated
| modified_time = utils.strptime_with_tz(datetime.datetime.strptime( | ||
| modified_time_org, "%Y-%m-%dT%H:%M:%S.%fZ").strftime("%Y-%m-%dT%H:%M:%SZ")) | ||
|
|
||
| # Checking the bookmark value is present and the record is having |
There was a problem hiding this comment.
Can we reword this to make it a little more clear?
Maybe something like:
Checking the bookmark value is present on the record and it
is greater than or equal to defined previous bookmark value
kethan1122
reviewed
Feb 8, 2023
kethan1122
approved these changes
Feb 9, 2023
sgandhi1311
force-pushed
the
TDL-21819-tickets-stream-dev-changes
branch
from
05760b7
to
265b06e
Compare
kethan1122
approved these changes
Feb 15, 2023
* add tickets stream in base.py file * get ticket records * add create ticket function for integration test case * test tickets stream in interrupt sync mode * Changes: - add page limit - add functions to get, create, and update the tickets stream * modify get logic for tickets in client.py and update sync offset test * address review comments and reformat the client.py as per the standards * Formatting changes in client.py and bookmark key change in interrupt sync test
bryantgray
approved these changes
Feb 15, 2023
RushiT0122
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
ticketsto list all associations of a ticket by object type. (API doc link)ticketsManual QA steps
Risks
Rollback steps