Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed precision of numbers from e-8 to e-20 #24

Merged
merged 3 commits into from Jan 19, 2021
Merged

changed precision of numbers from e-8 to e-20 #24

merged 3 commits into from Jan 19, 2021

Conversation

jacobrobertbaca
Copy link
Contributor

@jacobrobertbaca jacobrobertbaca commented Jan 15, 2021 •
edited

Description of change

changed precision of numbers from e-8 to e-15

Manual QA steps

  • nothing

Risks

  • not sure, i don't think there are many risks, but I want to discuss with someone first
  • tests aren't working now, so that adds to the risk a bit

Rollback steps

  • revert this branch

@cosimon cosimon changed the title changed precision of numbers from e-8 to e-15 changed precision of numbers from e-8 to e-20 Jan 19, 2021
@cosimon cosimon merged commit bbd104b into master Jan 19, 2021
@cosimon cosimon deleted the add_precision_to_numbers branch January 19, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaf-erlich asaf-erlich asaf-erlich approved these changes

@cosimon cosimon cosimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobrobertbaca @asaf-erlich @cosimon