Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdl-22339 Use query tunneling to allow large number of accounts #60

Merged
merged 4 commits into from Mar 22, 2023

Conversation

leslievandemark
Copy link
Contributor

Description of change

A large number of accounts will cause the API to error because the request URI is too long. This PR adds query tunneling to allow larger URIs and clients to enter many accounts
https://learn.microsoft.com/en-us/linkedin/shared/api-guide/concepts/query-tunneling?context=linkedin/context

Manual QA steps

  • pr alphad with Tdl 22339 client, and resolved the error they were receiving.

Risks

  • low - the tap should function the same, this just changes the way a request is sent. However, we never got feedback from Tdl 22339, just saw that there error was resolved and they were able to sync.

Rollback steps

  • revert this branch

@leslievandemark leslievandemark changed the title Tdl 22339 Use query tunneling to allow large number of accounts Tdl-22339 Use query tunneling to allow large number of accounts Mar 22, 2023
@leslievandemark leslievandemark merged commit 2fd6814 into master Mar 22, 2023
@leslievandemark leslievandemark deleted the TDL-22339/improve-error-messaging branch March 22, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants