Added date_window property for reports_email_activity stream
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vi6hal
changed the title
date_window property for reports_email_activity stream
zachharris1
previously requested changes
Jun 5, 2023
…o/tap-mailchimp into TDL-23005-campaigns-date-window
sgandhi1311
reviewed
Jun 8, 2023
Co-authored-by: Sourabh Gandhi <105213416+sgandhi1311@users.noreply.github.com>
Vi6hal
commented
Jun 8, 2023
sgandhi1311
approved these changes
Jun 8, 2023
Vi6hal
dismissed
zachharris1’s stale review
I have made the requested change, removing this review to unblock the P.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The currently implementation fetches the reports_email_activity for all streams, which is not ideal when users have a lot of campaigns and only a few get used often, hence the date_window parameter will accept a value numeric value
Xthis will only fetch the campaign_ids that are fetched in the last
XdaysManual QA steps
Risks
Rollback steps