TDL-5784 Add export_events param #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
approved these changes
Oct 11, 2022
savan-chovatiya
approved these changes
Oct 11, 2022
| @@ -152,3 +152,4 @@ def test_run(self): | |||
| # Pagination test for EU residency server | |||
| self.eu_residency = True | |||
| self.pagination_test_run() | |||
|
|
|||
There was a problem hiding this comment.
it doesn't look like export events were actually added to this test?
There was a problem hiding this comment.
Yeah, created env variable for export_events param and also adjusted start date since data was missing for export stream. So, I had to generate test data for export stream and accordingly adjusted the start date
leslievandemark
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
export_eventsparam to fetch specific events.Manual QA steps
export_eventsparam value and verified that tap fetch only specified events.0records when user sets an invalid event name in the config.Risks
Rollback steps