Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-24216 Rename URI options #107

Merged
merged 2 commits into from Oct 5, 2023
Merged

TDL-24216 Rename URI options #107

merged 2 commits into from Oct 5, 2023

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Sep 28, 2023 •
edited by dsprayberry

Description of change

This PR updates one of the keys according to the PyMongo 4 Migration Guide.

Instead of ssl.CERT_NONE, ssl.CERT_OPTIONAL and ssl.CERT_REQUIRED, the new option expects a boolean value - True is equivalent to ssl.CERT_NONE, while False is equivalent to ssl.CERT_REQUIRED.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch, bump the version

@luandy64 luandy64 merged commit 3eef5da into master Oct 5, 2023
5 checks passed
@luandy64 luandy64 deleted the TDL-24216/migrate-to-pymongo-4-params branch October 5, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsprayberry dsprayberry dsprayberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luandy64 @dsprayberry