Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify mode option to config #38

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

dmosorast
Copy link
Contributor

Description of change

Change verify mode to be an optional config argument, instead of assuming that using an SSH tunnel invalidates the Subject of the SSL cert verification.

verify_mode defaults to "true" and removing it will disable Certificate Name verification on the connection. This is useful if you have a self-signed cert attached to your mongo instance or for some other network topological reason the name verification doesn't apply.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • None. Relying on automation to run through the code and confirm that this has no effect on existing configs.

Risks

Low, this is an additive optional property. In most cases it should have no effect.

Rollback steps

  • revert this branch

@dmosorast dmosorast merged commit 40de408 into master Feb 11, 2020
@dmosorast dmosorast deleted the feature/add_verify_mode_option branch February 11, 2020 16:05
@dmosorast dmosorast mentioned this pull request Feb 11, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants