[TDL-24255] Fix for attribute & generated relationship name #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam for followUpSequenceId attribute.
shantanu73
changed the title
|
Did an alpha for the customer and their connection is working now with changes in this PR. |
cosimon
reviewed
Oct 6, 2023
tap_outreach/sync.py
Outdated
| @@ -251,7 +251,7 @@ def process_records(stream, mdata, max_modified, records, filter_field, fks): | |||
| 'null or `id` field expected for `data` relationship') | |||
|
|
|||
| # potential fix for the issue - https://github.com/singer-io/tap-outreach/issues/20 | |||
| if stream.tap_stream_id not in ["prospects", "events"]: | |||
| if stream.tap_stream_id not in ["prospects", "events", "mailings"]: | |||
There was a problem hiding this comment.
If a stream encountering this exception means we have to come in and say "and don't throw for this stream" then why are we throwing this exception at all?
There was a problem hiding this comment.
We should consider overriding the key value from the relationships as per the Outreach support -
…generated relationship name.
sgandhi1311
approved these changes
Oct 9, 2023
cosimon
requested changes
Oct 9, 2023
cosimon
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
JIRA
Fixed attribute & generated relationship name issue with mailings stream for followUpSequenceId attribute.
Manual QA steps
Risks
Rollback steps