Tdl 21520 skip donotprocess records #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
requested review from
dmosorast and
luandy64
and removed request for
dmosorast
rdeshmukh15
reviewed
Dec 23, 2022
tap_pendo/streams.py
Outdated
| parent_last_updated = datetime.fromtimestamp(float(record['metadata']['auto'][self.replication_key]) / 1000.0, timezone.utc) | ||
| # If there is no last_update key then set 'last_updated=now()' and fetch the records from recent bookmark | ||
| parent_last_updated = datetime.fromtimestamp(float( | ||
| record['metadata']['auto'][self.replication_key]) / 1000.0, timezone.utc) if record['metadata']['auto'].get(self.replication_key) else now() |
There was a problem hiding this comment.
140 characters on one line which is too long. Can you please align it properly. 100 chars per line are preferred.
There was a problem hiding this comment.
Do we know under what scenarios a record will not have a last_update key? Is it linked exclusively to visitors with do_not_process flags set?
rdeshmukh15
reviewed
Dec 23, 2022
.circleci/config.yml
Outdated
| @@ -22,7 +22,7 @@ jobs: | |||
| command: | | |||
| source /usr/local/share/virtualenvs/tap-pendo/bin/activate | |||
| # TODO: Adjust the pylint disables | |||
| pylint tap_pendo --disable 'broad-except,chained-comparison,empty-docstring,fixme,invalid-name,line-too-long,missing-class-docstring,missing-function-docstring,missing-module-docstring,no-else-raise,no-else-return,too-few-public-methods,too-many-arguments,too-many-branches,too-many-lines,too-many-locals,ungrouped-imports,wrong-spelling-in-comment,wrong-spelling-in-docstring,bad-whitespace,missing-class-docstring' | |||
| pylint tap_pendo --disable 'broad-except,chained-comparison,empty-docstring,fixme,invalid-name,line-too-long,missing-class-docstring,missing-function-docstring,missing-module-docstring,no-else-raise,no-else-return,too-few-public-methods,too-many-arguments,too-many-branches,too-many-lines,too-many-locals,ungrouped-imports,wrong-spelling-in-comment,wrong-spelling-in-docstring,bad-whitespace,missing-class-docstring,too-many-statements' | |||
There was a problem hiding this comment.
break into multiple lines for readability purpose.
dsprayberry
requested changes
Dec 28, 2022
dsprayberry
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
If any visitor is set the Do Not Process flag then Pendo will stop collecting events from that visitor and will stop displaying guides to that visitor. In such scenario we should skip fetching visitor_history.
Manual QA steps
donotprocessrecords are getting skipped.Risks
Rollback steps