TDL-19176: Add backoff/retry for 5xx errors #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachharris1
reviewed
Jun 5, 2023
| # pipedrive object | ||
| pipedrive_tap = _tap.PipedriveTap(config, {}) | ||
|
|
||
| def test_json_decode_successfull_with_200(self, mocked_jsondecode_successful_request, mocked_sleep): |
There was a problem hiding this comment.
Why is mocked_sleep passed in to all these functions?
There was a problem hiding this comment.
if you look at the code here, it has two decorators. each representing the parameters of the methods. by passing the mocked_sleep we are instructing the unit-test to skip the backoff time when encountering the exception. If we remove both mocked_sleep and its respective decorator then the unit-test will take time mentioned here to complete. So, we add the mocked_sleep and its decorator to skip the waiting time for unit-tests
There was a problem hiding this comment.
Ah I see. Cool, sounds good to me. I'll approve.
zachharris1
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-19176: Add backoff/retry for 5xx errors
Manual QA steps
Risks
Rollback steps