Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Type Information in JSON Schema #62

Merged
merged 4 commits into from Feb 7, 2024

Conversation

sgandhi1311
Copy link
Member

Description of change

The type of the elements within the array is missing, which in result generates the invalid schema. This potentially leads to errors during the data loading process.
One of the connections encounters the below error while loading the output in the target -

2024-02-01 20:59:35,436Z   main - ERROR Target exited abnormally with status 1. Terminating tap.
2024-02-01 20:59:35,439Z   main - INFO No tunnel subprocess to tear down
2024-02-01 20:59:35,439Z   main - INFO Exit status is: Discovery succeeded. Tap succeeded. Target failed with code 1 and error message: "Error persisting data to Stitch: 400: {'error': 'Invalid JSON schema: key null: expected type is one of JSONObject, found: String'}".

Manual QA steps

  • Tested the schema and output record with target-stitch
  • Fixed the unit tests
  • Integration tests are also passing

Risks

  • High, if it disrupts the existing catalog it may cause an issue.

Rollback steps

  • revert this branch

@sgandhi1311 sgandhi1311 merged commit e08e93b into master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants