api version upgrade #181
Merged
api version upgrade #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
force-pushed
the
TDL-23422-api-version-upgrade
branch
from
1125160
to
6754bc0
Compare
luandy64
reviewed
Aug 10, 2023
tests/utils_invoices.py
Outdated
Comment on lines
14
to
23
| item = stripe.InvoiceItem.create( | ||
| amount=random.randint(1, 10000), | ||
| currency="usd", | ||
| customer=customer_id, | ||
| description="Comfortable cotton t-shirt {}".format(now_value), | ||
| metadata=metadata_value, | ||
| discountable=True, | ||
| subscription_item=None, | ||
| tax_rates=[], # TODO enter the child attributes | ||
| stripe_version = '2020-08-27' |
There was a problem hiding this comment.
Indent these like you have below
luandy64
reviewed
Aug 10, 2023
tests/utils_invoices.py
Outdated
Comment on lines
34
to
37
| # custom_fields={ | ||
| # 'name': 'CustomName', | ||
| # 'value': 'CustomValue', | ||
| # }, |
luandy64
reviewed
Aug 10, 2023
tests/test_all_fields.py
Outdated
Comment on lines
54
to
60
| # Fields which are deprecated and no longer will come in the response of api | ||
| deprecated_fields = { | ||
| 'payment_intents': { | ||
| 'charges' | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this just be included in FIELDS_TO_NOT_CHECK?
luandy64
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps