Tiktok API version upgrade schema changes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanu73
reviewed
Jul 20, 2023
shantanu73
approved these changes
Jul 21, 2023
sgandhi1311
force-pushed
the
TDL-22949-schema-changes
branch
from
93f5f36
to
0a9621f
Compare
* Add new stream - campaign_insights_by_province * update base.py with the new stream - campaign_insights_by_province * remove user_action field from the campaign insights stream * update the README.md file to include the latest stream details. * format the campaign insights json file * update field type for conversion rates * remove campaigns by province stream from start date and pagination
* Refactoring the code * add custom field-current_status in the schema * add param primary_status with value STATUS_DELETE to retrieve deleted records * fix the code for getting values from config * move the refactoring code to different branch * add unit test case to check the flow * fix failing test case * add current_status field in the adgroups and advertiser schema
sgandhi1311
added a commit
that referenced
this pull request
Aug 17, 2023
* modify API endpoint * add fields in the campaigns schema * schema changes for adgroup * fix unit test * Schema changes for ads stream * advertisers schema change * update Advertisers key properties * update field types for insight/s streams * set the advertiser_id if it is not present in record * update placement field to placement_type * setup and changelog updates * add few more fields in the ads and adgroups stream * pass the advertiser_id in the param as json formatted string * fix failing unit test cases * update changelog * add new fields for the insight related streams * address review comments * add new field - rf_campaign_type in the schemas * remove aeo_type field * update primary key for advertisers stream in the base.py * modify all fields test * update docs links in readme * update field type for conversion rates * retry for code - 40100 * fix the integration tests * remove few fields from test all field test * Introduce new stream - campaign_insights_by_province (#25) * Add new stream - campaign_insights_by_province * update base.py with the new stream - campaign_insights_by_province * remove user_action field from the campaign insights stream * update the README.md file to include the latest stream details. * format the campaign insights json file * update field type for conversion rates * remove campaigns by province stream from start date and pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Introduce new stream (campaign_insights_by_province)- #25
Manual QA steps
Risks
Rollback steps