Fix landings pagination #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@KrisPersonal here's the code coverage for this tap |
luandy64
requested changes
Oct 20, 2021
tap_typeform/streams.py
Outdated
| while page_count > 1: | ||
| response = get_landings(atx, form_id, token, next_page=True) | ||
| page_count = response.get('page_count', 1) | ||
| data.extend(response.get('items'), []) |
Contributor
There was a problem hiding this comment.
I think this is the wrong approach. We could hit a memory limit by holding on to every page with this extend.
Is there an advantage to this over writing a page of records at a time?
Contributor
Author
There was a problem hiding this comment.
That is valid, I've moved the pagination to get_landings() and it now yields one page at a time
luandy64
approved these changes
Oct 26, 2021
|
Hello - is there anything I need to do on my end in order to see these changes in my database? |
Merged
hanyufoodles
added a commit
to hanyufoodles/tap-typeform
that referenced
this pull request
Dec 23, 2021
This reverts commit b52decc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added pagination to the
landingsstream as per TDL-15821Should close: #47, #25, and #28
Manual QA steps
singer-check-tapandtarget-stitch --dry-runRisks
Rollback steps