Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdl 595 add quotes stream support #86

Merged
merged 7 commits into from Apr 13, 2021

Conversation

karanpanchal-crest
Copy link
Contributor

Description of change

  • Added support of quotes stream

Manual QA steps

  • Verified that the tap is collecting data for the Quotes stream when selected.

Risks

  • No Risks

Rollback steps

  • revert this branch

Copy link
Contributor

@KAllan357 KAllan357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that's left here is to add tap-tester tests which confirm the new stream is syncing data successfully.

@KAllan357 KAllan357 merged commit 7d2900b into master Apr 13, 2021
@KAllan357 KAllan357 deleted the TDL-595-add-quotes-stream-support branch April 13, 2021 13:23
@karanpanchal-crest
Copy link
Contributor Author

All that's left here is to add tap-tester tests which confirm the new stream is syncing data successfully.

@KAllan357 As discussed in the sync-up meeting, integration tests added in this PR suffices the verification of Quotes stream support.
Let me know if any thing else is required to be incorporated in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants