Skip to content

add deleted=true param to reviews request#55

Merged
bryantgray merged 2 commits into
masterfrom
TDL-22385/sync-deleted-reviews
Mar 17, 2023
Merged

add deleted=true param to reviews request#55
bryantgray merged 2 commits into
masterfrom
TDL-22385/sync-deleted-reviews

Conversation

@bryantgray

Copy link
Copy Markdown
Contributor

Description of change

reviews stream used to request deleted reviews. The v2.0.0 update removed this from the request.
This change adds the deleted=true param back to the reviews request.

Manual QA steps

  • Verified same records returned on v2 as v1 with param added

Risks

  • Any syncs that were run with v2 will need to reset to get all deleted reviews

Rollback steps

  • revert this branch

@vishalp-dev
vishalp-dev self-requested a review March 17, 2023 06:07
@rdeshmukh15
rdeshmukh15 self-requested a review March 17, 2023 06:28
@bryantgray
bryantgray merged commit 85ed24a into master Mar 17, 2023
@bryantgray
bryantgray deleted the TDL-22385/sync-deleted-reviews branch March 17, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants