Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deleted=true param to reviews request #55

Merged
merged 2 commits into from Mar 17, 2023
Merged

add deleted=true param to reviews request #55

merged 2 commits into from Mar 17, 2023

Conversation

bryantgray
Copy link
Contributor

Description of change

reviews stream used to request deleted reviews. The v2.0.0 update removed this from the request.
This change adds the deleted=true param back to the reviews request.

Manual QA steps

  • Verified same records returned on v2 as v1 with param added

Risks

  • Any syncs that were run with v2 will need to reset to get all deleted reviews

Rollback steps

  • revert this branch

@Vi6hal Vi6hal self-requested a review March 17, 2023 06:07
@rdeshmukh15 rdeshmukh15 self-requested a review March 17, 2023 06:28
@bryantgray bryantgray merged commit 85ed24a into master Mar 17, 2023
1 check failed
@bryantgray bryantgray deleted the TDL-22385/sync-deleted-reviews branch March 17, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vi6hal Vi6hal Vi6hal approved these changes

@rdeshmukh15 rdeshmukh15 rdeshmukh15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryantgray @Vi6hal @rdeshmukh15