Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backoff for ConnectionResetError, ChunkedEncodingError and ProtocolError #132

Merged
merged 7 commits into from Jun 8, 2023

Conversation

kethan1122
Copy link
Contributor

@kethan1122 kethan1122 commented Jun 5, 2023

Description of change

Duplicates #131 for all the connections using 1.x versions
Adds backoff for ChunkedEncodingError, ProtocolError and ConnectionResetError

- urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
- requests.exceptions.ChunkedEncodingError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))

Manual QA steps

Risks

  • Low

Rollback steps

  • revert this branch

@kethan1122 kethan1122 changed the title add backoff for ConnectionError and ConnectionResetError add backoff for ConnectionResetError, ChunkedEncodingError and ProtocolError Jun 5, 2023
@RushiT0122 RushiT0122 self-requested a review June 7, 2023 12:56
test/base.py Outdated
Comment on lines 362 to 365
try:
return dt.utcfromtimestamp(int(date_value))
except ValueError:
LOGGER.warning(f"cannot convert {date_value} to int ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, we can skip this logger statement here.

Suggested change
try:
return dt.utcfromtimestamp(int(date_value))
except ValueError:
LOGGER.warning(f"cannot convert {date_value} to int ")
try:
return dt.utcfromtimestamp(int(date_value))
except ValueError:
pass

Copy link
Contributor

@RushiT0122 RushiT0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor change.

@kethan1122 kethan1122 merged commit f9dbd8c into 1.latest Jun 8, 2023
3 checks passed
@kethan1122 kethan1122 deleted the add-backoff-for-version-1 branch June 8, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants