Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass linestyle to embeded block #1230

Merged
merged 1 commit into from
May 24, 2023
Merged

pass linestyle to embeded block #1230

merged 1 commit into from
May 24, 2023

Conversation

doonfrs
Copy link
Contributor

@doonfrs doonfrs commented May 24, 2023

I needed to embed icons in the editor, and I needed the icon to take the same line font size, I found that I had no access to the line style from the embedded builder.
This will be helpful for inline embedded blocks.

image

Example code: I can access the font size now ( and other styles for sure)
image

@singerdmx singerdmx merged commit f56d5c3 into singerdmx:master May 24, 2023
@bambinoua
Copy link
Contributor

bambinoua commented May 24, 2023

@doonfrs man did you overview the code of the package? Your change is broken! You updated the prototype of EmbedBuild.build (add new parameter textStyle) but this affects all widges which depends on it namely ImageEmbedBuilder, ImageEmbedBuilderWeb, ImageVideoBuilder and now the project which use them is not compiled!

@MacDeveloper1 MacDeveloper1 mentioned this pull request May 24, 2023
singerdmx pushed a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants