Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old functionaliy for some Quill toolbar classes #1633

Closed
wants to merge 15 commits into from

Conversation

MacDeveloper1
Copy link
Contributor

Description

Today I have again spent time to make my project looks as it must. I do not do anything critical just restore the funcitonality of some toolbar classes as they were. You may consider this PR as a starting point for all other buttons which I didn't change. The only thing is required is change call of QuillToolbarIconButton in build methods of embed buttons, search button and maybe others. You may see what I did. I also restored old QuillToolbarSelectAlignmentButton and save it as QuillToolbarSelectTextAlignmentButton.

I need this modifications to make my project compiled and continue working. You may merge this PR or use it for understanding how to make package backward compatible. It will take less effors.

Related Issues

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@MacDeveloper1
Copy link
Contributor Author

If we solve the conflicts and merge this, does that fix your issue?

I restored only buttons which I used but there are other ones which are not fixed.
I think the package should works properly for Material 2 and Material 3. This is the only thing you should care. Agree?

So if button in web looks like

image

before modifications it should looks like so after modifications but not like

image

I tested example app so you may read #1628 (comment) for results.

@singerdmx singerdmx closed this Jun 14, 2024
@ellet0
Copy link
Collaborator

ellet0 commented Jun 14, 2024

This issue can be solved without reverting, it's looks like the issue is caused by using the new Material 3 recommended widgets instead of the previous ones that work for Material 2 and 3, updating to 9.x.x require using Material 3 and the new widgets listed in Flutter 3.16 in additional to other changes.

See the following for more details and suggestions:

If you have any questions or suggestions, don't hesitate to create a new discussion or leave a comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed properties, classes and no backward compatible with material 2 version for flutter web
3 participants