Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Undo/redo cursor position fixed #1885

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

Alspb
Copy link
Contributor

@Alspb Alspb commented May 20, 2024

Description

Fixed cursor position after Undo/Redo.

Related Issues

Fixes #1289, #1005.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@singerdmx singerdmx merged commit ef06a44 into singerdmx:master May 21, 2024
2 checks passed
@ellet0
Copy link
Collaborator

ellet0 commented May 21, 2024

Thank you for your contributions

Not related to the PR: I noticed the names we use for the variables are very short and can be unclear for developers who are new to the project. We might want to use longer and more descriptive names

For example,len might or might not indicate its length also, it's not clear length of what exactly, or something like v which is not clear to most developers

Thank you once again.

@Alspb
Copy link
Contributor Author

Alspb commented May 28, 2024

I agree.
In this particular PR I tried to preserve the names but probably it's better to change them when working on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile] or [Desktop]: Undo errors
3 participants